Modified the examples for mb_convert_kana, mb_detect_encoding, mb_encode_numericentity#4510
Conversation
…ode_numericentity
youkidearitai
left a comment
youkidearitai
left a comment
There was a problem hiding this comment.
Looks good. One point.
| string(8) "SJIS-win" | ||
| string(5) "ASCII" | ||
| ]]> | ||
| </screen> |
There was a problem hiding this comment.
Hmm... I think confuse to put example of output.
The result of mb_detect_encoding is different in several version. Ref: https://3v4l.org/rf0FG
Because this function is tuning in heuristics. Maybe behavior changes to this function.
@alexdowad Do you have any opinion?
There was a problem hiding this comment.
I really would like that we add some huge warnings that this function is badly named and is far from accurate.
derickr
left a comment
derickr
left a comment
There was a problem hiding this comment.
Looks good with the additional language phrasing change.
| The name of this function is misleading, it performs "guessing" rather than "detection". | ||
| </para> | ||
| <para> | ||
| The guesses are far from accurate, and cannot use this function to accurately detect |
There was a problem hiding this comment.
The guesses are far from accurate, and therefore you cannot use this function to accurately detect reads a little better to me.
|
Can I merge this? |
4 participants
No description provided.